Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix explain(locus) issues. #433

Merged
merged 1 commit into from
May 16, 2024
Merged

Conversation

avamingli
Copy link
Contributor

Fix typo and locus null as below.

explain (costs off, locus)
select * from dedup_reptab r where r.a in (select t.a/10 from dedup_tab t);
                                      QUERY PLAN
------------------------------------------------------------------------
 Gather Motion 3:1  (slice1; segments: 3)
   Locus: Entry
   ->  Result
         Locus: Strewn
         ->  Unique
               Locus: NULL
               Group Key: (RowIdExpr)
               ->  Sort
                     Locus: NULL
                     Sort Key (Distinct): (RowIdExpr)
                     ->  Redistribute Motion 3:3  (slice2; segments: 3)
                           Locus: Hashed
                           Hash Key: (RowIdExpr)
                           ->  Hash Join
                                 Locus: Hashed
                                 Hash Cond: ((t.a / 10) = r.a)
                                 ->  Seq Scan on dedup_tab t
                                       Locus: Hashed
                                 ->  Hash
                                       Locus: Replicated
                                       ->  Broadcast Motion 1:3
(slice3; segments: 1)
                                             Locus: Replicated
                                             ->  Seq Scan on
dedup_reptab r
                                                   Locus: SingleQE

Authored-by: Zhang Mingli avamingli@gmail.com

fix #ISSUE_Number


Change logs

Describe your change clearly, including what problem is being solved or what feature is being added.

If it has some breaking backward or forward compatibility, please clary.

Why are the changes needed?

Describe why the changes are necessary.

Does this PR introduce any user-facing change?

If yes, please clarify the previous behavior and the change this PR proposes.

How was this patch tested?

Please detail how the changes were tested, including manual tests and any relevant unit or integration tests.

Contributor's Checklist

Here are some reminders and checklists before/when submitting your pull request, please check them:

  • Make sure your Pull Request has a clear title and commit message. You can take git-commit template as a reference.
  • Sign the Contributor License Agreement as prompted for your first-time contribution(One-time setup).
  • Learn the coding contribution guide, including our code conventions, workflow and more.
  • List your communication in the GitHub Issues or Discussions (if has or needed).
  • Document changes.
  • Add tests for the change
  • Pass make installcheck
  • Pass make -C src/test installcheck-cbdb-parallel
  • Feel free to request cloudberrydb/dev team for review and approval when your PR is ready🥳

Fix typo and locus null as below.

explain (costs off, locus)
select * from dedup_reptab r where r.a in (select t.a/10 from dedup_tab
t);
                                      QUERY PLAN
------------------------------------------------------------------------
 Gather Motion 3:1  (slice1; segments: 3)
   Locus: Entry
   ->  Result
         Locus: Strewn
         ->  Unique
               Locus: NULL
               Group Key: (RowIdExpr)
               ->  Sort
                     Locus: NULL
                     Sort Key (Distinct): (RowIdExpr)
                     ->  Redistribute Motion 3:3  (slice2; segments: 3)
                           Locus: Hashed
                           Hash Key: (RowIdExpr)
                           ->  Hash Join
                                 Locus: Hashed
                                 Hash Cond: ((t.a / 10) = r.a)
                                 ->  Seq Scan on dedup_tab t
                                       Locus: Hashed
                                 ->  Hash
                                       Locus: Replicated
                                       ->  Broadcast Motion 1:3
(slice3; segments: 1)
                                             Locus: Replicated
                                             ->  Seq Scan on
dedup_reptab r
                                                   Locus: SingleQE

Authored-by: Zhang Mingli avamingli@gmail.com
@avamingli avamingli force-pushed the fix_explain_locus branch from 10bca62 to bd518d8 Compare May 14, 2024 02:55
@avamingli avamingli merged commit 6bf35c8 into apache:main May 16, 2024
10 checks passed
@avamingli avamingli deleted the fix_explain_locus branch May 16, 2024 11:41
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants